-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1320 Add module TypeScript definitions #2282
base: main
Are you sure you want to change the base?
Conversation
b5d26eb
to
3916290
Compare
3916290
to
6eee5aa
Compare
Hi @samueldmeyer Thanks for the PR. Could you please fix the DCO issue and also attach the issue 1320 like below in the PR above Dev Certificate ? |
382ada2
to
65fbffe
Compare
@srikant-ch5 I've fixed the DCO issue, updated the message, and rebased on the commits added since I started this PR |
@srikant-ch5 Is there anything else I need to do for this pull request? |
Hi @samueldmeyer -- I think I was supposed to look through this. Apologies for not doing so, I've been concentrating on some of the features you asked for. At first glance I wonder whether we need some tests (presumably Jest tests) to test at least some of this? Also, I think @matthoward366, @nmgokhale and @caritaou should review the Common Properties parts of this since they will need to maintain this Type script API going forward. |
Signed-off-by: Samuel Meyer <[email protected]>
9d8c847
to
b79c89a
Compare
Signed-off-by: Samuel Meyer <[email protected]>
b79c89a
to
df90abe
Compare
@tomlyn I added tests using tsd, which is the standard for TypeScript definitions inside the library. I didn't test everything because a lot of that would simply be a repeat of what is in the definitions, but I did test the parts that are more complicated and generally made it extensible for adding tests. I added the tests to |
Signed-off-by: Samuel Meyer <[email protected]>
7702209
to
c687c20
Compare
Fixes: #1320
Developer's Certificate of Origin 1.1